Add support for searching for alternate invocees for externs #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For certain C# methods, Udon exposes the method via a different type than Roslyn considers it to be defined on. One example is `System.Type.Name`, which is actually defined in `System.Reflection.MemberInfo`, but exposed via `System.Type.Name`. This change allows U# to locate these alternate extern symbols and use them transparently. We move the logic for checking whether symbols are exposed to udon down into BoundExternMethodInvocation, then teach this class to search declared interfaces and superclasses of the _invocation_ target (rather than the symbol's containing type) for defined externs. Note that we assume that any exposed extern will match if we find it via a constructed symbol here.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For certain C# methods, Udon exposes the method via a different type than Roslyn considers it to be defined on. One example is
System.Type.Name, which is actually defined inSystem.Reflection.MemberInfo, but exposed viaSystem.Type.Name.This change allows U# to locate these alternate extern symbols and use them transparently. We move the logic for checking whether
symbols are exposed to udon down into BoundExternMethodInvocation, then teach this class to search declared interfaces and
superclasses of the invocation target (rather than the symbol's containing type) for defined externs.
Note that we assume that any exposed extern will match if we find it via a constructed symbol here.
Note: This is more-or-less a straight rebase of MerlinVR#129 .
I'm currently unable to add new tests to the integration test scene on this branch, due to what I suspect
are issues related to the serialization branch. For now I'm putting this PR up in case you can get the test
suite working on your machine; it at least does not seem to cause new regressions.