-
-
Notifications
You must be signed in to change notification settings - Fork 11.5k
[CI] Fix flaky CI test #12626
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI] Fix flaky CI test #12626
Conversation
Signed-off-by: NickLucche <[email protected]>
Signed-off-by: NickLucche <[email protected]>
|
👋 Hi! Thank you for contributing to the vLLM project. Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can do one of these:
🚀 |
|
It looks like now we have OOM error, can you fix it? |
|
@DarkLight1337 I've looked into it but I am not sure what's causing the OOM at loading time on L40s. It appears we're at the limit of what can be fit on that gpu, but the math doesn't check out to me. We should be loading (approx): 2x6.5gb models + 2x0.5 activations=>only 5gb of kv cache left to split among scorer and drafter. Yet profiling reports 12gb of kvcache, as it wasn't accounting for the draft model.. Issue can be reproduced on L40 even with tp=1. |
|
cc @LiuXiaoxuanPKU for memory profiling in spec decode. |
|
This pull request has merge conflicts that must be resolved before it can be |
|
This pull request has been automatically marked as stale because it has not had any activity within 90 days. It will be automatically closed if no further activity occurs within 30 days. Leave a comment if you feel this pull request should remain open. Thank you! |
|
This pull request has been automatically closed due to inactivity. Please feel free to reopen if you intend to continue working on it. Thank you! |
There's a test suite that's currently disabled #12240 due to a flaky test, in which the output tokens end up being slightly different wrt the baseline (here's the test https://github.com/vllm-project/vllm/blob/main/tests/spec_decode/e2e/test_integration_dist_tp2.py#L104).
Issue is only reproducible with tp>1.
Due to it being a slight change of phrasing in the output sentence, I suspect it might be a numerical issue (as also noted in the original PR that introduced it #6050 (comment)). Tests are now passing both with fp32 and fp16 accuracy, but I'll be on the lookout in case it errors out again.