-
Notifications
You must be signed in to change notification settings - Fork 173
feat: Support generic categories and MMLR-Pro mapping #192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Support generic categories and MMLR-Pro mapping #192
Conversation
✅ Deploy Preview for vllm-semantic-router ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
👥 vLLM Semantic Team NotificationThe following members have been identified for the changed files in this PR and have been automatically assigned: 📁
|
src/semantic-router/pkg/utils/classification/classifier_test.go
Outdated
Show resolved
Hide resolved
Signed-off-by: Jintao Zhang <[email protected]>
7022251
to
6f247e5
Compare
/hold for a while, will review tomorrow |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, has left some comments. pls take a look.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code overall looks good to me, plz add UT around this feature
Signed-off-by: Jintao Zhang <[email protected]>
/lgtm |
What type of PR is this?
feat: Support generic categories and MMLR-Pro mapping
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #119
Release Notes: Yes/No