Skip to content

Various Small Tooling Fixes/Features #239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Aug 20, 2025
Merged

Various Small Tooling Fixes/Features #239

merged 10 commits into from
Aug 20, 2025

Conversation

sjmonson
Copy link
Collaborator

@sjmonson sjmonson commented Jul 23, 2025 •
edited
Loading

Summary

Miscellaneous selection of small tooling changes.

Details

  • Add dependency-groups dev group for tools that automatically install development packages
  • Add pylock for synchronizing package versions across maintainers
  • Match tox python version matrix to 3.9-3.12
  • Drop the broken PR build job
  • Drop mypy from pre-commit checks

Test Plan

  • TODO

Related Issues

  • TODO
  • "I certify that all code in this PR is my own, except as noted below."

Use of AI

  • Includes AI-assisted code completion
  • Includes code generated by an AI application
  • Includes AI-generated tests (NOTE: AI written tests should have a docstring that includes ## WRITTEN BY AI ##)

@sjmonson sjmonson force-pushed the cleanup/python_tooling branch from cb6dab8 to 3c94d6e Compare July 30, 2025 22:09
@sjmonson sjmonson self-assigned this Aug 1, 2025
@sjmonson sjmonson force-pushed the cleanup/python_tooling branch from ac82ecb to ac8a077 Compare August 5, 2025 18:04
@sjmonson sjmonson added this to the v0.3.0 milestone Aug 13, 2025
@sjmonson sjmonson changed the title WIP: Various Small Tooling Fixes/Features Various Small Tooling Fixes/Features Aug 20, 2025
@sjmonson sjmonson force-pushed the cleanup/python_tooling branch from ac8a077 to 6c4e5fa Compare August 20, 2025 14:05
@sjmonson sjmonson marked this pull request as ready for review August 20, 2025 14:06
AlonKellner-RedHat
AlonKellner-RedHat previously approved these changes Aug 20, 2025
View reviewed changes
Copy link
Collaborator

@AlonKellner-RedHat AlonKellner-RedHat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall I approve, this PR is very needed. Still, please go through my comments and consider fixing them 😄

@sjmonson sjmonson force-pushed the cleanup/python_tooling branch from d3a6991 to 2201c48 Compare August 20, 2025 14:49
markurtz
markurtz previously approved these changes Aug 20, 2025
View reviewed changes
@sjmonson sjmonson dismissed stale reviews from markurtz and AlonKellner-RedHat via 07da8ca August 20, 2025 17:17
@sjmonson sjmonson force-pushed the cleanup/python_tooling branch 3 times, most recently from 0310aba to c83d6d1 Compare August 20, 2025 17:38
@sjmonson
Add dependency-groups for dev tools
543ef24 
Signed-off-by: Samuel Monson <[email protected]>
@sjmonson
Add a pylock managed by pdm
25effbc 
Signed-off-by: Samuel Monson <[email protected]>
@sjmonson
Update tox python version matrix
eed9cfc 
Signed-off-by: Samuel Monson <[email protected]>
@sjmonson
Drop broken build job
b44d07b 
Signed-off-by: Samuel Monson <[email protected]>
@sjmonson
Drop mypy pre-commit check
f108b1e 
Signed-off-by: Samuel Monson <[email protected]>
@sjmonson
pre-commit autoupdate
adac21f 
Signed-off-by: Samuel Monson <[email protected]>
@sjmonson
Implement previously missed typechecks
d157db2 
Signed-off-by: Samuel Monson <[email protected]>
@sjmonson sjmonson force-pushed the cleanup/python_tooling branch from c83d6d1 to f5a7019 Compare August 20, 2025 17:41
@sjmonson
Loosen version req on dev deps
135c5de 
Signed-off-by: Samuel Monson <[email protected]>
@sjmonson sjmonson force-pushed the cleanup/python_tooling branch from f5a7019 to 135c5de Compare August 20, 2025 17:58
@markurtz markurtz merged commit 7f2fbeb into main Aug 20, 2025
16 of 17 checks passed
@markurtz markurtz deleted the cleanup/python_tooling branch August 20, 2025 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markurtz markurtz markurtz approved these changes

@jaredoconnell jaredoconnell jaredoconnell approved these changes

@AlonKellner-RedHat AlonKellner-RedHat AlonKellner-RedHat left review comments

Assignees

@sjmonson sjmonson

Labels
None yet
Projects
None yet
Milestone
v0.3.0
Development

Successfully merging this pull request may close these issues.
4 participants
@sjmonson @markurtz @jaredoconnell @AlonKellner-RedHat