Skip to content

Conversation

@sapphi-red
Copy link
Member

Description

Specified the peer dependencies version range.
Previously, we used *, which didn't clearly communicate which versions were actually supported. For example, #19977 requires sass 1.45.0+ and #19978 requires sass 1.70.0+, but this isn't obvious from the current package.json and it wasn't clear whether relying on which feature would require a major version.

Here's the reasoning behind the chosen ranges for each peer dependency:

@sapphi-red sapphi-red added the p1-chore Doesn't change code behavior (priority) label May 1, 2025
@sapphi-red sapphi-red added this to the 7.0 milestone May 1, 2025
@sapphi-red sapphi-red merged commit c9bfd57 into vitejs:main May 16, 2025
16 checks passed
@sapphi-red sapphi-red deleted the chore/declare-version-for-peer-dependencies branch May 16, 2025 01:57
moonlitusun pushed a commit to moonlitusun/vite that referenced this pull request May 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

p1-chore Doesn't change code behavior (priority)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants