Use findInternal instead of acquire #5
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vinser52
reviewed
Nov 10, 2023
|
|
||
| auto allocFn = [&](std::string keyPrefix, std::vector<uint32_t> sizes) { | ||
| for (unsigned int loop = 0; loop < 20; ++loop) { | ||
| std::vector<typename AllocatorT::WriteHandle> parentHandles; |
There was a problem hiding this comment.
removed - it was leftover from initial test that I used as base
| while (alloc->getSlabReleaseStats().numSlabReleaseForRebalance < 20) { | ||
| sleep(1); | ||
| } | ||
| //for ASSERT_EXIT |
There was a problem hiding this comment.
I did not get why we need exit(0)
There was a problem hiding this comment.
Because we use the ASSERT_EXIT to check if CacheLib aborts due to mismatched parent handle or if the test completes with no aborts.
byrnedj
force-pushed
the
fix_acquire_rebased
branch
2 times, most recently
from
115789f to
fb8e23c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as a bonus - we have a proper test