Rebased develop #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vinser52
pushed a commit
that referenced
this pull request
Sep 1, 2022
Hot queue iterator for 2Q. Will start at Hot queue and move to Warm queue if hot queue is exhausted. Useful for promotion semantics if using 2Q replacement. rebased on to develop and added some tests.
vinser52
pushed a commit
that referenced
this pull request
Dec 15, 2022
Summary: The current exception string for MapIndexMaxedOut is not very useful because ```oldHashTable.viewWriteHandle()->getKey()``` can have null terminators in it and cause the c_str() to be terminated incorrectly. Regardless, the actual write handle key is not very useful to us. Log the aid explicitly. Example log: ``` Sep 14 07:12:57 tsp_lla/tao/prod-opt-follower/1879 dpdaemon[442]: E0914 07:12:57.836133 1922 Refill.cpp:215] Index has maxed out for key: #1<A4><D1 (https://github.com/facebook/CacheLib/commit/3ec18f5591f75fa5e247cadad19a86126075bdda)>0F<F6>\ ``` Reviewed By: vrishal Differential Revision: D39518530 fbshipit-source-id: 58b9f31f6c0d174d5ec0bc7705788408bc0d11f4
vinser52
pushed a commit
that referenced
this pull request
Apr 27, 2023
Hot queue iterator for 2Q. Will start at Hot queue and move to Warm queue if hot queue is exhausted. Useful for promotion semantics if using 2Q replacement. rebased on to develop and added some tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.