Skip to content

feat: insert subnet #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 6, 2023
Merged

feat: insert subnet #3

merged 1 commit into from
Mar 6, 2023

Conversation

@vimt
Copy link
Owner

@vimt vimt commented Feb 21, 2023

Close #2

writer.insert_network(IPSet(['1.0.0.0/8']), info1)
# we can insert instead of ignore when insert subnet of exist cidr
writer.insert_network(IPSet(['1.10.10.0/24']), info2)

@vimt
Copy link
Owner Author

vimt commented Feb 21, 2023

@FynnMazurkiewicz Please review this PR.
And it would be better if you can raise PR next time😊

@vimt vimt merged commit 82fabc6 into master Mar 6, 2023
@vimt vimt deleted the feature/insert-subnet branch March 6, 2023 13:59
@FynnMazurkiewicz
Copy link

FynnMazurkiewicz commented Mar 6, 2023

@vimt Hi, I actually saw it and it looked fine! Glad to got it in 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Subnet inserts

3 participants

@vimt @FynnMazurkiewicz