Add option to disable NBF claim during ecoding #416
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Thanks! I'll give this a look over as soon as I can! |
|
I think you got a typo in |
Contributor
Author
|
Thanks @augustozanellato, just fixed it! |
Contributor
|
Sorry it's taking me so long here, life has been hectic. I'll make sure to take some time after work today to give this a good look over and cut a new release 👍 |
Contributor
Author
|
Don't worry @vimalloc-mavenlink, take your time. |
vimalloc
approved these changes
May 2, 2021
Owner
vimalloc
left a comment
vimalloc
left a comment
There was a problem hiding this comment.
Looks great, thanks for contributing! 👍
Owner
|
Released in v4.2.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the JWT RFC states that the 'use of this claim is OPTIONAL' and @vimalloc (at #384) was inclined to add this feature, I took the liberty to hack together a possible solution.
I also updated in this merge request the documentation and added test cases for both scenarios.
Hope this comes useful.