Iss #35 Added a config option to control setting session or persisten… #36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t cookies. The options getters seem to be merging app config and default config as transparently as possible so I added a helper method in utils.py, _get_cookie_max_age, to translate the true/false value into something meaningful for flask's set_cookie max_age parameter. Tests have been run on Python 2.7 only! This has also been installed on a flask app and tested manually.
Owner
|
This looks fantastic! Thanks for contributing! 👍 I will bet a new release with this pushed asap. |
Author
|
Thanks, and no problem. I'm always happy to find ways to give back. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…t cookies.
The options getters seem to be merging app config and default config as
transparently as possible so I added a helper method in utils.py,
_get_cookie_max_age, to translate the true/false value into something
meaningful for flask's set_cookie max_age parameter.
Tests have been run on Python 2.7 only! This has also been installed on
a flask app and tested manually.