Use the order of values in JWT_TOKEN_LOCATION to set order of precedence #256
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @stephendwolff! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2019-07-03 15:13:56 UTC |
vimalloc
requested changes
Jul 2, 2019
Owner
vimalloc
left a comment
vimalloc
left a comment
There was a problem hiding this comment.
One minor thing, otherwise looks great!
|
|
||
| # add the functions in the order specified in JWT_TOKEN_LOCATION | ||
| for location in locations: | ||
| if location == 'cookies' and config.jwt_in_cookies: |
Owner
There was a problem hiding this comment.
I think we can get rid of the config.jwt_in_cookies (et al) from these if statements, as they are doing the same check that we are doing here.
Owner
|
I think the way you have it where if there is a valid token higher up in the token location list supersedes an invalid token later in token location list makes the most sense 👍 |
vimalloc
approved these changes
Jul 3, 2019
Owner
|
Looks great! Thanks for contributing! I'll get a new version released momentarily. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added the update to run the token validation in the order set in JWT_TOKEN_LOCATION, and this allows a valid token earlier in the list to authenticate the user, and invalid to be ignored if later.
This suits my use case - but perhaps another option could be to require no invalid tokens?
I wrote a couple of tests, and fixed one of the error messages in the existing multiple token location test.
Also, I added a note to the configuration options documentation for JWT_TOKEN_LOCATION