Skip to content

Conversation

ankit-v2-3
Copy link
Collaborator

@ankit-v2-3 ankit-v2-3 commented Dec 28, 2023

Pull Request

Description:
Add play() method to Video, SearchResult, Shot object. and play_stream() utility function

Refactor:
Video class
self.stream_link -> self.stream_url
self.player_url (new self variable for player link)
self.thumbnail -> self.thumbnail_url
video.get_stream() -> video.generate_stream()
video.get_thumbnail() -> video.generate_thumbnail()
video.play() (new method open the player url in the default browser/notebook and return player url.)

SearchResult class
self.stream_link -> self.stream_url
self.player_url (new self variable for player link)
result.play() (new method open the player url in the default browser/notebook and return player url.)

Shot class
self.stream -> self.stream_url
self.player_url (new self variable for player link)
short.get_stream() -> shot.generate_stream( )
shot.play() (new method open the player url in the default browser/notebook and return player url.)

Changes:

  • Add player

Checklist:

  • Code follows project coding standards
  • Tests have been added or updated
  • Code Review
  • Manual test after merge
  • All checks passed

@ashish-spext ashish-spext merged commit 0fb1f53 into main Dec 28, 2023
@ankit-v2-3 ankit-v2-3 deleted the ar/add-player branch December 28, 2023 15:17
ankit-v2-3 pushed a commit that referenced this pull request Mar 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants