Enable ci for external collaborators #325
Conversation
|
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
pranaygp
force-pushed
the
pranaygp/external-collaborator-ci
branch
from
89ee70c to
d6888f2
Compare
pranaygp
force-pushed
the
pranaygp/external-collaborator-ci
branch
from
d6888f2 to
ad93a6f
Compare
| github-token: ${{ secrets.GITHUB_TOKEN }} | ||
| result-encoding: string | ||
| script: | | ||
| try { |
There was a problem hiding this comment.
I'd prefer we pull these out into script files, like here.
| with: | ||
| github-token: ${{ secrets.GITHUB_TOKEN }} | ||
| script: | | ||
| await github.rest.issues.createComment({ |
There was a problem hiding this comment.
Not sure we need to post a comment on the PR. Maybe just no-op.
| const timestamp = new Date().getTime(); | ||
| const ciBranchName = `ci-test/${prDetails.number}-${timestamp}`; | ||
|
|
||
| // Add remote for the external fork if it's from a fork |
There was a problem hiding this comment.
It would always be from a fork, no?
| script: | | ||
| const prDetails = ${{ steps.pr-details.outputs.result }}; | ||
| const timestamp = new Date().getTime(); | ||
| const ciBranchName = `ci-test/${prDetails.number}-${timestamp}`; |
There was a problem hiding this comment.
timestamp seems unnecessary. PR numbers are unique.
Unless we are planning on creating a new branch each time this workflow is run, but my thinking was that we'd have a 1:1 relationship, and the test PR would update if the branch already exists and /run-ci is invoked for future updates on a given PR. Maybe this is fine for now as
Add new
/run-cicommand to allow repo admins to trigger a CI run for external collaborator PRsLeaving in draft just so we remove the claude generated md files before actually merging :)