-
Notifications
You must be signed in to change notification settings - Fork 29.8k
fix: Narrow down from string | undefined to string
#65248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
eps1lon
merged 9 commits into
vercel:canary
from
icyJoseph:fix/empty_NEXT_PUBLIC_env_vars
Jun 26, 2024
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
40f3075
fix: Narrow down from `string | undefined` to `string`
icyJoseph 744b530
test: Empty env vars are the same, before and after hydration
icyJoseph a8b4075
Merge branch 'canary' into fix/empty_NEXT_PUBLIC_env_vars
icyJoseph a088591
Merge branch 'canary' into fix/empty_NEXT_PUBLIC_env_vars
icyJoseph 03ac007
Merge branch 'canary' into fix/empty_NEXT_PUBLIC_env_vars
icyJoseph 233e7ac
Merge branch 'canary' into fix/empty_NEXT_PUBLIC_env_vars
icyJoseph f29770e
Merge branch 'canary' into fix/empty_NEXT_PUBLIC_env_vars
icyJoseph b392d42
Merge branch 'canary' into fix/empty_NEXT_PUBLIC_env_vars
devjiwonchoi b240a4f
Merge branch 'canary' into fix/empty_NEXT_PUBLIC_env_vars
devjiwonchoi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -25,13 +25,14 @@ const variables = [ | |
| 'NEW_ENV_LOCAL_KEY', | ||
| 'NEW_ENV_DEV_KEY', | ||
| 'NEXT_PUBLIC_HELLO_WORLD', | ||
| 'NEXT_PUBLIC_EMPTY_ENV_VAR', | ||
| ] | ||
|
|
||
| export async function getStaticProps() { | ||
| const items = {} | ||
|
|
||
| variables.forEach((variable) => { | ||
| if (process.env[variable]) { | ||
| if (typeof process.env[variable] !== 'undefined') { | ||
|
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. the other test pages on this integration suite, do the very same check |
||
| items[variable] = process.env[variable] | ||
| } | ||
| }) | ||
|
|
@@ -53,6 +54,9 @@ export default function Page({ env }) { | |
| <div id="nextConfigNewPublicEnv"> | ||
| {process.env.NEXT_PUBLIC_NEW_NEXT_CONFIG_VALUE} | ||
| </div> | ||
| <div id="nextPublicEmptyEnvVar"> | ||
| {`${process.env.NEXT_PUBLIC_EMPTY_ENV_VAR}`} | ||
| </div> | ||
| </> | ||
| ) | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.