Skip to content

Enable concurrent mode by default in app-render #39307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 3, 2022
Merged

Enable concurrent mode by default in app-render #39307

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions packages/next/server/app-render.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -413,7 +413,6 @@ export async function renderToHTMLOrFlight(
buildManifest,
serverComponentManifest,
supportsDynamicHTML,
runtime,
ComponentMod,
} = renderOpts

Expand Down Expand Up @@ -1046,11 +1045,9 @@ export async function renderToHTMLOrFlight(
},
})

const hasConcurrentFeatures = !!runtime

return await continueFromInitialStream(renderStream, {
dataStream: serverComponentsInlinedTransformStream?.readable,
generateStaticHTML: generateStaticHTML || !hasConcurrentFeatures,
generateStaticHTML: generateStaticHTML,
flushEffectHandler,
flushEffectsToHead: true,
initialStylesheets,
Expand Down
1 change: 0 additions & 1 deletion test/e2e/app-dir/app-rendering/next.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
module.exports = {
experimental: {
appDir: true,
runtime: 'nodejs',
serverComponents: true,
},
}
1 change: 0 additions & 1 deletion test/e2e/app-dir/app/next.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
module.exports = {
experimental: {
appDir: true,
runtime: 'nodejs',
serverComponents: true,
legacyBrowsers: false,
browsersListForSwc: true,
Expand Down
1 change: 0 additions & 1 deletion test/e2e/app-dir/rsc-basic/next.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@ module.exports = {
},
experimental: {
appDir: true,
runtime: 'nodejs',
serverComponents: true,
},
}