Skip to content

Fix export issue in with-fauna example #38812

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 20, 2022
Merged

Fix export issue in with-fauna example #38812

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c00e4bb
Fix export issue in with-fauna example
trevor-fauna Jul 19, 2022
73dc195
lint fix
trevor-fauna Jul 19, 2022
422eb3f
Apply suggestions from code review
ijjk Jul 20, 2022
05d8bb0
update
ijjk Jul 20, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions examples/with-fauna/lib/constants.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
const resolveDbDomain = () => {
return process.env.FAUNA_DB_DOMAIN ?? 'db.fauna.com'
}

module.exports = {
resolveDbDomain,
}
2 changes: 1 addition & 1 deletion examples/with-fauna/lib/fauna.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { GraphQLClient, gql } from 'graphql-request'
import { resolveDbDomain } from '../scripts/setup'
import { resolveDbDomain } from './constants'

const CLIENT_SECRET =
process.env.FAUNA_ADMIN_KEY || process.env.FAUNA_CLIENT_SECRET
Expand Down
5 changes: 1 addition & 4 deletions examples/with-fauna/scripts/setup.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ const readline = require('readline')
const request = require('request')
const { Client, query: Q } = require('faunadb')
const streamToPromise = require('stream-to-promise')
const { resolveDbDomain } = require('../lib/constants')

const MakeLatestEntriesIndex = () =>
Q.CreateIndex({
Expand Down Expand Up @@ -114,10 +115,6 @@ const resolveAdminKey = () => {
})
}

const resolveDbDomain = () => {
return process.env.FAUNA_DB_DOMAIN ?? 'db.fauna.com'
}

const importSchema = (adminKey) => {
let domain = resolveDbDomain().replace('db', 'graphql')
return streamToPromise(
Expand Down