-
Notifications
You must be signed in to change notification settings - Fork 29.9k
[Examples] chore:with-sentry-update-dependencies #38051
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Examples] chore:with-sentry-update-dependencies #38051
Conversation
balazsorban44
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you verify that you have tested this? Since this is a major upgrade, I wonder if the breaking changes should be addressed: https://github.com/getsentry/sentry-javascript/releases/tag/7.0.0
As I read from releases 7.0.0 note there is no affect from this breaking changes to examples/with-sentry since we didn't use BrowerTracing api?
However this is result of my tests! So first I config my personal SENTRY_DSN from .env.local then use
and test with
Client test
SSR test |
…hub.com/chaiwattsw/next.js into example/with-sentry-update-dependencies
|
Let me know if you need anything else @balazsorban44 |
|
@chaiwattsw - Thanks for doing this! I need to do the |
@lobsterkatie You're welcome! I'm fine with it, Would be better if you do the rest anyway. |
Yes, please. In porting over your changes, I took a closer look and realized that not all of them actually should come over. As far as |
Bug