Skip to content

Update _error.tsx #26335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 4 commits into from
Closed

Update _error.tsx #26335

wants to merge 4 commits into from

Conversation

designdevy
Copy link

@designdevy designdevy commented Jun 18, 2021 •
edited
Loading

Fixed uneven layout for ErrorPage

image

image

Reference URL: https://www.designdev.io/asdsadsa

Bug

  • Related issues linked using fixes #number
  • Integration tests added

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.

Documentation / Examples

  • Make sure the linting passes

@designdevy
Update _error.tsx
3e6322e 
Fixed uneven layout
@designdevy
Copy link
Author

Hi, I tried to find any snapshots but didn't find any so I opened the PR. Please let me know if there are any related tests that need to be updated.

ijjk
ijjk reviewed May 22, 2022
View reviewed changes
Copy link
Member

@ijjk ijjk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, this appears to already be fixed in the latest canary, please update and give it a try!

Screen Shot 2022-05-22 at 6 02 47 PM

@ijjk ijjk closed this May 22, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ijjk ijjk ijjk left review comments

@divmain divmain Awaiting requested review from divmain

@lfades lfades Awaiting requested review from lfades

@shuding shuding Awaiting requested review from shuding

@timneutkens timneutkens Awaiting requested review from timneutkens

@huozhi huozhi Awaiting requested review from huozhi

@padmaia padmaia Awaiting requested review from padmaia

@styfle styfle Awaiting requested review from styfle

Assignees
No one assigned
Labels
type: next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@designdevy @ijjk