Compatibility with jsonapi-resources 0.10

[valscion]

Seems like we will have to do some work in the future to be compatible with upcoming JR version, 0.10, where resources being closely coupled to ActiveRecord is being worked on.

@hidde-jan in #48 (comment)

Are there any thoughts on how (or if) to incorporate cerebris/jsonapi-resources#1006 and cerebris/jsonapi-resources#977?

From JA:R 0.10 onward, the idea is to delegate record fetching to a RecordAccessor.

In the future, the logic in PunditScopedResource might need to be moved into such a class.

---

EDIT:

• See Fix a bug for checking JSONAPI::Relationship::ToOne authorization #82 for a case where a new upcoming release caused compatibility issues with upstream

[valscion]

Ok JR 0.10 has been released now. It seems that the major changes done are things concerning jsonapi-authorization, so it will take quite an effort to get us compatible with it.

https://jsonapi-resources.com/v0.10/guide/whats_new.html

We should update this gem to be compatible with JR 0.10 and release a new major version to support only that version. People on older versions could use older versions of jsonapi-authorization.

Any help is appreciated. I don't have time any time soon to look into this and neither is this a priority on our team any time soon.

[rpbaltazar]

@valscion do you have any sort of tasklist of things that need to be touched ?
I could possibly have some time to try to push this forward.

[valscion]

Not really, sorry.

One thing I'd really like to see here would be a new approach to tests where we would assert on user visible functionality — so going from a full request to an expected authorization error without relying on any stubbing.

Some of the current tests have gotten so complex due to the authorization stubbing going on that I have a lack of trust on any big changes done to the existing tests.

These new types of tests could first start small and test only a subset of the authorization logic. I'd like them to be in a totally different directory than the existing RSpec tests, and as self-contained as possible. Meaning that the resources, controllers and policies needed for the tests would all be in one file, even if it would make for a longer file.

This type of tests could be done with minitest instead of RSpec, too.

[romikoops]

Hello, any progress with supporting 0.10? 4 months since issue opening.

[valscion]

Does not seem like it. Feel free to offer help if you need JR 0.10 support.