Skip to content

ci: Enables opt-in wasm CI build for sql-kit #191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

scottmarchant
Copy link
Contributor

⚠️ This PR is blocked from final testing and merging until dependent PR's are both merged and released. I added issues to the diff that I will resolve once everything is ready to resolve.

Change summary

Added swift wasm as a opt-in CI target, to help prevent future breakages to swift wasm builds.

This PR is part of a larger effort by PassiveLogic to add wasm support to many popular repositories.

Notes

  • CI for this won't pass until a future swift-nio version is ready. See details below.

PR Dependencies

The following PR's must be merged before this PR can be merged:

Testing done

Verified this new workflow functions correctly using a temporary PR that enables the new wasm build.

See https://github.com/PassiveLogic/sql-kit/actions/runs/15886122859/job/44798410586?pr=1

Remaining work

  • Run tests on this once all dependent PR's are merged and released.

@@ -15,6 +15,7 @@ jobs:
secrets: inherit
with:
with_android: true
with_wasm: true
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: We need to wait to merge this PR until all dependencies are merged/released. I'll resolve this issue once that is done.

@scottmarchant
Copy link
Contributor Author

Hi @gwynne, do you know if there is a way for me to trigger CI here to verify my changes work as expected?

@scottmarchant
Copy link
Contributor Author

Decided to cherry pick this change to #190, so that #190 can be tested for WASM compilation.

@scottmarchant scottmarchant deleted the feat/add-swift-wasm-ci branch July 14, 2025 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant