Bump ubuntu version for thrift builds #47
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Пропустили один момент с обновлением трифта на 0.17.0 - при сборке бинарника у нас использовался тег
ubuntu-latestvalitydev/thrift/.github/workflows/build-and-upload-binaries-after-release.yaml
Из-за этого трифт собрался на 22.04, а при сборке протоколов сейчас используется ubuntu-20.04 (
valitydev/java-workflow/.github/workflows/maven-thrift-build.yml
). В ней более старая версия glibc, из-за чего трифт отказывается стартовать: https://github.com/valitydev/mayday-proto/actions/runs/5013023006/jobs/8985631531. Всё это время его просто никто не использовал похоже (у нас в целом и протоколы новые не пилились) + все сидели на прошлой версии.