Skip to content

fix: allow number arg to be optional #194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 8, 2025
Merged

fix: allow number arg to be optional #194

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8153f1f
fix: allow `number` arg to be optional
kricsleo Apr 8, 2025
6c02233
chore: apply automated updates
autofix-ci[bot] Apr 8, 2025
3ec12de
lint
kricsleo Apr 8, 2025
7308f5f
Merge branches 'fix/number-arg' and 'fix/number-arg' of github.com:kr…
kricsleo Apr 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions src/args.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,16 @@
);
}
} else if (arg.type === "number") {
if (parsedArgsProxy[arg.name] === undefined) {
if (arg.required) {
throw new CLIError(
`Missing required argument: --${arg.name}`,
"EARG",
);
}
continue;
}

Check warning on line 88 in src/args.ts

View check run for this annotation

Codecov / codecov/patch

src/args.ts#L81-L88 

Added lines #L81 - L88 were not covered by tests

const _originalValue = parsedArgsProxy[arg.name];
parsedArgsProxy[arg.name] = Number.parseFloat(
parsedArgsProxy[arg.name] as string,
Expand Down