Use fastcrc, instead of custom implementation, make modules proper python, and use prebuild cyclonedds #107
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a few changes that make the library easier to install and more compatible with different developer machines (without performance trade-off).
fastcrcpython library for native, fast CRC implementation support on more platforms (including Mac/darwin), so falling back to pure python implementation is no longer necessary. Also makes the CRC implementation more transparent/auditable, since the source code for the crc library used currently is not available.__init__.pyin their roots, so they are compatible with all python dependency tooling.cyclonedds @ 0.10.5I have made and published in https://github.com/carlosdp/cyclonedds-python , so developers never have to build cyclone on their own! That part of the README can be removed after this change.The net effect of this PR is that this SDK can be installed with just
pip install git+https://github.com/unitreerobotics/unitree_sdk2_python🎉🥳