-
Notifications
You must be signed in to change notification settings - Fork 810
Update migration instructions for payment providers #7479
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Additional changes to add : Vendr.Services.CurrencyService.GetCurrency(ctx.Order.CurrencyId); to be replaced with injected ICurrencyService Vendr.Services.CountryService.GetCountry(ctx.Order.PaymentInfo.CountryId.Value) to be replaced with injected ICountryService |
|
And IVendrBuilder to IUmbracoCommerceBuilder |
|
Also mention about ModelsBuilder - eg Homepage node has a reference to Store, but the namespaces no longer exist. |
|
Changes to Order.AddProduct, writeableOrder.AddProduct |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes mostly look good (have given feedback on what needs changing), but the PR discussion mentions other changes needed that aren't part of this PR. These either need implementing, or moving to an Issue so that they don't get lost when the PR is merged.
|
|
||
| ```bash | ||
| dotnet remove package Umbraco.Commerce.Core | ||
| dotnet remove package Vendr.Core |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should probably just be Vendr
| Throughout the following steps, we will migrate custom payment providers used for Umbraco Commerce into Umbraco Commerce. | ||
|
|
||
| 1. Remove any installed Umbraco Commerce packages | ||
| 1. Remove any installed Vendr.Core packages |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should probably just be Vendr
|
The note about other places was to myself really to remember to change it for the namespaces. There were some bits about IVendrBuilder to IUmbracoCommerceBuilder which I can add if you're happy to hold on for a bit Also thanks for your help resolving that product adapter issue :-) |
Updated instructions on the upgrade from Vendr to Umbraco Commerce to fix issues with the SQL