Skip to content

Conversation

@CarlSargunar
Copy link
Contributor

@CarlSargunar CarlSargunar commented Oct 8, 2025

Updated instructions on the upgrade from Vendr to Umbraco Commerce to fix issues with the SQL

  • sp_rename was erroring when I ran it, corrected the syntax
  • Corrected namespace on custom providers
  • Fixed an issue with the data type of a colum - was nText, which was deprecated, had to convert to nvarchar(max)

@CarlSargunar
Copy link
Contributor Author

Additional changes to add : Vendr.Services.CurrencyService.GetCurrency(ctx.Order.CurrencyId); to be replaced with injected ICurrencyService

Vendr.Services.CountryService.GetCountry(ctx.Order.PaymentInfo.CountryId.Value) to be replaced with injected ICountryService

@CarlSargunar
Copy link
Contributor Author

And IVendrBuilder to IUmbracoCommerceBuilder

@CarlSargunar
Copy link
Contributor Author

CarlSargunar commented Oct 8, 2025

Also mention about ModelsBuilder - eg Homepage node has a reference to Store, but the namespaces no longer exist.

	///<summary>
	/// Store
	///</summary>
	[global::System.CodeDom.Compiler.GeneratedCodeAttribute("Umbraco.ModelsBuilder.Embedded", "10.8.11+d8f68d2")]
	[global::System.Diagnostics.CodeAnalysis.MaybeNull]
	[ImplementPropertyType("store")]
	public virtual global::Umbraco.Commerce.Core.Models.StoreReadOnly Store => this.Value<global::Umbraco.Commerce.Core.Models.StoreReadOnly>(_publishedValueFallback, "store");

@CarlSargunar
Copy link
Contributor Author

Changes to Order.AddProduct, writeableOrder.AddProduct

@CarlSargunar CarlSargunar marked this pull request as ready for review October 15, 2025 12:45
Copy link
Contributor

@mattbrailsford mattbrailsford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes mostly look good (have given feedback on what needs changing), but the PR discussion mentions other changes needed that aren't part of this PR. These either need implementing, or moving to an Issue so that they don't get lost when the PR is merged.


```bash
dotnet remove package Umbraco.Commerce.Core
dotnet remove package Vendr.Core
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should probably just be Vendr

Throughout the following steps, we will migrate custom payment providers used for Umbraco Commerce into Umbraco Commerce.

1. Remove any installed Umbraco Commerce packages
1. Remove any installed Vendr.Core packages
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should probably just be Vendr

@CarlSargunar
Copy link
Contributor Author

CarlSargunar commented Oct 17, 2025

The note about other places was to myself really to remember to change it for the namespaces. There were some bits about IVendrBuilder to IUmbracoCommerceBuilder which I can add if you're happy to hold on for a bit

Also thanks for your help resolving that product adapter issue :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants