Folder Workspace: Support menu expansion and breadcrumbs (closes # #20712
+246
−37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR refactors menu manifests for various content types to use constant aliases instead of hardcoded strings, and adds menu structure and breadcrumb support for folder workspaces. The changes improve maintainability by centralizing workspace alias definitions and extend functionality to folder-type entities.
Key Changes:
- Replaced hardcoded string literals like
'Umb.Workspace.Stylesheet'with imported constants (e.g.,UMB_STYLESHEET_WORKSPACE_ALIAS) - Added new menu structure workspace contexts and breadcrumb footer apps for folder workspaces across multiple content types
- Reorganized document blueprint manifests structure (renamed
menu-itemtomenuand added constants)
Reviewed Changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/Umbraco.Web.UI.Client/src/packages/templating/stylesheets/menu/manifests.ts | Replaced hardcoded workspace alias strings with constants; added folder menu structure and breadcrumb manifests |
| src/Umbraco.Web.UI.Client/src/packages/templating/scripts/menu/manifests.ts | Replaced hardcoded workspace alias strings with constants; added folder menu structure and breadcrumb manifests |
| src/Umbraco.Web.UI.Client/src/packages/templating/partial-views/menu/manifests.ts | Replaced hardcoded workspace alias strings with constants; added folder menu structure and breadcrumb manifests |
| src/Umbraco.Web.UI.Client/src/packages/media/media-types/menu/manifests.ts | Replaced hardcoded workspace alias strings with constants; added folder menu structure and breadcrumb manifests |
| src/Umbraco.Web.UI.Client/src/packages/documents/document-types/menu/manifests.ts | Replaced hardcoded workspace alias strings with constants; added folder menu structure and breadcrumb manifests |
| src/Umbraco.Web.UI.Client/src/packages/documents/document-blueprints/menu/manifests.ts | Replaced hardcoded menu item alias with constant |
| src/Umbraco.Web.UI.Client/src/packages/documents/document-blueprints/menu/document-blueprint-menu-structure.context.ts | New file: Added menu structure workspace context for document blueprints |
| src/Umbraco.Web.UI.Client/src/packages/documents/document-blueprints/menu/constants.ts | New file: Exported menu item alias constant |
| src/Umbraco.Web.UI.Client/src/packages/documents/document-blueprints/manifests.ts | Renamed menu-item import to menu |
| src/Umbraco.Web.UI.Client/src/packages/documents/document-blueprints/constants.ts | Added menu constants export; reordered exports alphabetically |
| src/Umbraco.Web.UI.Client/src/packages/data-type/menu/manifests.ts | Replaced hardcoded workspace alias strings with constants; added folder menu structure and breadcrumb manifests |
| src/Umbraco.Web.UI.Client/src/packages/core/menu/menu-variant-tree-structure-workspace-context-base.ts | Added alias parameter to observe call for better debugging |
| src/Umbraco.Web.UI.Client/src/packages/core/menu/menu-tree-structure-workspace-context-base.ts | Added #isNew field; optimized observe logic to only request structure on state transitions; added alias parameters; includes debugger statement |
| } | ||
|
|
||
| async #requestStructure() { | ||
| debugger; |
There was a problem hiding this comment.
Remove the debugger statement before committing. This should not be in production code.
Suggested change
| debugger; |
madsrasmussen
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #20675
This PR registers the missing extensions to support menu expansion in the active workspace and display the breadcrumbs.
Two issues that will need to be addressed in other PRs: