Skip to content

Conversation

@belugabehr
Copy link

There is no need to use String#format with SLF4J as SLF4J supports its own formatting mechanism called an "anchor."

http://www.slf4j.org/faq.html#logging_performance

Remove a bunch of instances of this practice for clarity and it actually hurts performance for debug level logging as SLF4J is able to perform that anchor-substitution lazily, only if debug mode is enabled.

@belugabehr
Copy link
Author

Note: I didn't hit every instance, just some of the easier ones and don't want to commit to doing them all without some hope that this will be accepted. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant