Use field.id_for_label instead of field.auto_id #66
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikolas
force-pushed
the
use-id-for-label
branch
from
e1ad654 to
036517c
Compare
nikolas
force-pushed
the
use-id-for-label
branch
from
036517c to
0b18be1
Compare
This fixes a bug when specifying a custom id for a field and rendering it with the `|bootstrap` filter. When using `field.auto_id` in the label's `for` attribute, this is always set to the default value instead of the custom `id`. Also fix a typo in the tests: file_fied -> file_field
nikolas
force-pushed
the
use-id-for-label
branch
from
0b18be1 to
d219330
Compare
2 similar comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug when specifying a custom id for a field and rendering
it with the
|bootstrapfilter.When using
field.auto_idin the label'sforattribute, this isalways set to the default value instead of the custom
id.Also fix a typo in the tests:
file_fied->file_field