Skip to content

Fix dependency_order bug #83

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 4, 2023
Merged

Fix dependency_order bug #83

merged 2 commits into from
Jan 4, 2023

Conversation

@hauntsaninja
Copy link
Contributor

@hauntsaninja hauntsaninja commented Jan 4, 2023 •
edited
Loading

AlexWaygood
AlexWaygood approved these changes Jan 4, 2023
View reviewed changes
Copy link
Contributor

@AlexWaygood AlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense to me (though I'm pretty new to this codebase)

@JelleZijlstra JelleZijlstra merged commit 1b91343 into typeshed-internal:main Jan 4, 2023
@hauntsaninja hauntsaninja deleted the fix-dep-order branch January 4, 2023 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JelleZijlstra JelleZijlstra JelleZijlstra approved these changes

+1 more reviewer

@AlexWaygood AlexWaygood AlexWaygood approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@hauntsaninja @JelleZijlstra @AlexWaygood