Skip to content

Fix sort_by_dependency to work with non-standard dist names #80

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 14, 2022
Merged

Fix sort_by_dependency to work with non-standard dist names #80

merged 3 commits into from
Dec 14, 2022

Conversation

@srittau
Copy link
Member

@srittau srittau commented Dec 14, 2022

No description provided.

@srittau srittau mentioned this pull request Dec 14, 2022
Merged
@srittau
Copy link
Member Author

srittau commented Dec 14, 2022

There are two other uses of strip_types_prefix() that come into effect if a dependency is declared on a non-standard distribution name. This should be fixed eventually, but a not critical for now.

@srittau srittau merged commit 64f1de3 into main Dec 14, 2022
@srittau srittau deleted the distname branch December 14, 2022 11:24
@hauntsaninja hauntsaninja mentioned this pull request Jan 4, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ilevkivskyi ilevkivskyi ilevkivskyi approved these changes

+1 more reviewer

@AlexWaygood AlexWaygood AlexWaygood approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@srittau @ilevkivskyi @AlexWaygood