Skip to content

Conversation

highvolt-dev
Copy link
Contributor

@highvolt-dev highvolt-dev commented Feb 27, 2021

PR Checklist

Overview

Adds converter for codelyzer template-conditional-complexity rule which has been added to @angular-eslint.

@JoshuaKGoldberg JoshuaKGoldberg merged commit d55306a into typescript-eslint:main Mar 1, 2021
@KingDarBoja
Copy link
Collaborator

KingDarBoja commented Mar 6, 2021

@JoshuaKGoldberg I am trying to catch up with any merged pull request (I know, I have been lazy) and noticed this converter is missing the optional parameter as seen at angular-eslint-template/conditional-complexity file.

The fix should be mapping the number into maxComplexity. I will submit a PR in few minutes as it is a small change.

@JoshuaKGoldberg
Copy link
Member

Aha, good spot! I must have done a silly and missed that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Missing Codelyzr (Angular) rule: template-conditional-complexity

3 participants