Respect ESLint extensions in deduplicating rules and config writing #78
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
July 5, 2019 09:33
The original ESLint configuration is now included in the `writeConversionResults` written file with a single `...`. Additionally skipped outputting rules that match an existing ESLint plugin. If an extended ESLint plugin defines a rule with the same values as the resultant config, the config will skip printing it. This necessitated expanding "failures" to allow a new `ConfigurationError` type of error for unfound ESLint configurations. Renames "packages" in the configuration reading/converting logic areas to "plugins", as that's what ESLint calls them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
status: accepting prsOverview
The original ESLint configuration is now included in the
writeConversionResultswritten file with a single....Additionally skipped outputting rules that match an existing ESLint plugin. If an extended ESLint plugin defines a rule with the same values as the resultant config, the config will skip printing it.
This necessitated expanding "failures" to allow a new
ConfigurationErrortype of error for unfound ESLint configurations.Renames "packages" in the configuration reading/converting logic areas to "plugins", as that's what ESLint calls them.