Skip to content

Conversation

JoshuaKGoldberg
Copy link
Member

PR Checklist

Overview

If --comments is provided as true from having no globs passed to it, we'll now default to a configuration provided by --typescript if available. That necessitates passing in a found TypeScript configuration to convertComments.

Uses minimatch (already a transitive runtime dependency) to emulate TypeScript's exclude, files, and include.

@JoshuaKGoldberg JoshuaKGoldberg added the status: waiting for reviewer Waiting for a maintainer to review label Sep 8, 2020
@KingDarBoja
Copy link
Collaborator

LGTM 🚀 But I think it should support specifying a custom tsconfig file path as some projects would use a different path or inherit from a base option which is not fully complete (like monorepos or Angular ones).

@JoshuaKGoldberg
Copy link
Member Author

YES! Excellent idea, will file a followup issue! 👏

@JoshuaKGoldberg JoshuaKGoldberg removed the status: waiting for reviewer Waiting for a maintainer to review label Sep 8, 2020
@JoshuaKGoldberg JoshuaKGoldberg merged commit 24fe35f into main Sep 8, 2020
@JoshuaKGoldberg JoshuaKGoldberg deleted the comments-true branch September 8, 2020 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow tsconfig files and --typescript to inform --comment

2 participants