Skip to content

Add jsx-no-bind rule #654

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 29, 2020
Merged

Add jsx-no-bind rule #654

merged 2 commits into from
Jul 29, 2020

Conversation

@bhavinkotak07
Copy link
Contributor

@bhavinkotak07 bhavinkotak07 commented Jul 27, 2020 •
edited by JoshuaKGoldberg
Loading

PR Checklist

Overview

Currently the tslint-to-eslint-config doesn't support the rule "jsx-no-bind". This PR has a rule converter that addresses the issue

KingDarBoja
KingDarBoja approved these changes Jul 28, 2020
View reviewed changes
Copy link
Collaborator

@KingDarBoja KingDarBoja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing, looks good to me 💯

@KingDarBoja KingDarBoja added this to the Version 1.1 milestone Jul 28, 2020
JoshuaKGoldberg
JoshuaKGoldberg requested changes Jul 29, 2020
View reviewed changes
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Structurally looks great - just the notices addition, and we should be good to go!

@JoshuaKGoldberg JoshuaKGoldberg added the status: waiting for author The PR author should address requested changes label Jul 29, 2020
@JoshuaKGoldberg JoshuaKGoldberg modified the milestones: Version 1.1, Next Jul 29, 2020
JoshuaKGoldberg
JoshuaKGoldberg approved these changes Jul 29, 2020
View reviewed changes
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌 thanks!

@JoshuaKGoldberg JoshuaKGoldberg merged commit c7eb68e into typescript-eslint:master Jul 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JoshuaKGoldberg JoshuaKGoldberg JoshuaKGoldberg approved these changes

@KingDarBoja KingDarBoja KingDarBoja approved these changes

Assignees

No one assigned

Labels

status: waiting for author The PR author should address requested changes

Projects

None yet

Milestone

v1.2.0

Development

Successfully merging this pull request may close these issues.

Missing tslint-react rule: jsx-no-bind

3 participants

@bhavinkotak07 @JoshuaKGoldberg @KingDarBoja