improve type safety with regards to config files #601
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoshuaKGoldberg
requested changes
Jun 1, 2020
There was a problem hiding this comment.
I checked this branch out locally and it plays great - a lot of little edge cases fixed for. Thanks @bbarry!
Just requesting changes on the one type system test. I think we can get rid of it, but happy to discuss if you see a lot of value in keeping it?
JoshuaKGoldberg
added
the
status: waiting for author
JoshuaKGoldberg
approved these changes
Jun 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
status: accepting prsOverview
Last week I said I would look deeper at the poor
DeepPartial<T>type in #589It seems that this type needs to touch a number of config related places and there are several places where incomplete configurations might have slipped through but were fine according to tsc.