Skip to content

Conversation

@beenotung
Copy link
Contributor

to make the code more concise on array of union type

PR Checklist

Overview

Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agh, sorry, I was incorrect when I indicated array-simple would be an ok rule setting to take in. I was mixing it up with the default one that prefers T[], which is this repository's preference.

IMO Array<T> should be a discouraged construct in the type system because:

  • It's extra characters to achieve the same thing as T[]
  • JavaScript usage generally discourages Array(), with [] as the preference

@JoshuaKGoldberg
Copy link
Member

Closing this PR as non-actionable.

I know it must be annoying to have a change indicated as favorable in one PR and not in another, my sincere apologies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants