Adds no-for-in converter along with tests

src/rules/converters.ts

@@ -44,6 +44,7 @@ import { convertNoEmptyInterface } from "./converters/no-empty-interface";
 import { convertNoEval } from "./converters/no-eval";
 import { convertNoExplicitAny } from "./converters/no-explicit-any";
 import { convertNoFloatingPromises } from "./converters/no-floating-promises";
+import { convertNoForIn } from "./converters/no-for-in";
 import { convertNoForInArray } from "./converters/no-for-in-array";
 import { convertNoInferrableTypes } from "./converters/no-inferrable-types";
 import { convertNoInternalModule } from "./converters/no-internal-module";
@@ -137,6 +138,7 @@ export const converters = new Map([
     ["no-empty-interface", convertNoEmptyInterface],
     ["no-eval", convertNoEval],
     ["no-floating-promises", convertNoFloatingPromises],
+    ["no-for-in", convertNoForIn],
     ["no-for-in-array", convertNoForInArray],
     ["no-inferrable-types", convertNoInferrableTypes],
     ["no-internal-module", convertNoInternalModule],
@@ -229,7 +231,6 @@ export const converters = new Map([
     // tslint-microsoft-contrib rules:
     // ["max-func-body-length", convertMaxFuncBodyLength],
     // ["no-empty-line-after-opening-brace", convertNoEmptyLineAfterOpeningBrace], // padded-blocks
-    // ["no-for-in", convertNoForIn], // no-restricted-syntax config
     // ["no-function-expression", convertNoFunctionExpression], // ban-syntax config
     // ["no-suspicious-comment", convertNoSuspiciousComment],
     // ["no-with-statement", convertNoWithStatement],

src/rules/converters/no-for-in.ts

@@ -0,0 +1,14 @@
+import { RuleConverter } from "../converter";
+
+export const convertNoForIn: RuleConverter = tslintRule => {
+    return {
+        rules: [
+            {
+                ...(tslintRule.ruleArguments.length !== 0 && {
+                    ruleArguments: tslintRule.ruleArguments,
+                }),
+                ruleName: "no-restricted-syntax",
+            },
+        ],
+    };
+};

src/rules/converters/tests/no-for-in.test.ts

@@ -0,0 +1,67 @@
+import { convertNoForIn } from "../no-for-in";
+
+describe(convertNoForIn, () => {
+    test("conversion without arguments", () => {
+        const result = convertNoForIn({
+            ruleArguments: [],
+        });
+
+        expect(result).toEqual({
+            rules: [
+                {
+                    ruleName: "no-restricted-syntax",
+                },
+            ],
+        });
+    });
+    test("conversion with arguments", () => {
+        const result = convertNoForIn({
+            ruleArguments: ["error", "ForInStatement"],
+        });
+
+        expect(result).toEqual({
+            rules: [
+                {
+                    ruleName: "no-restricted-syntax",
+                    ruleArguments: ["error", "ForInStatement"],
+                },
+            ],
+        });
+    });
+    test("conversion with object arguments", () => {
+        const result = convertNoForIn({
+            ruleArguments: [{ selector: "ForInStatement", message: "For in is not allowed." }],
+        });
+
+        expect(result).toEqual({
+            rules: [
+                {
+                    ruleName: "no-restricted-syntax",
+                    ruleArguments: [
+                        { selector: "ForInStatement", message: "For in is not allowed." },
+                    ],
+                },
+            ],
+        });
+    });
+    test("conversion with mixed arguments", () => {
+        const result = convertNoForIn({
+            ruleArguments: [
+                "error",
+                { selector: "ForInStatement", message: "For in is not allowed." },
+            ],
+        });
+
+        expect(result).toEqual({
+            rules: [
+                {
+                    ruleName: "no-restricted-syntax",
+                    ruleArguments: [
+                        "error",
+                        { selector: "ForInStatement", message: "For in is not allowed." },
+                    ],
+                },
+            ],
+        });
+    });
+});