Conflict between tslint:align and @typescript-eslint/indent

[rhysowen9]

I'm running into a conflict between @typescript-eslint/indent and the align rule in @typescript-eslint/tslint/config, specifically with regard to the alignment of parameters on my class constructors.

🐛 Bug Report

• tslint-to-eslint-config version: 0.2.5
• ESLint version: 6.3.0
• Node version: 10.15.3

Actual Behavior

Expected indentation of x spaces but found x @typescript-eslint/indent
or
parameters are not aligned (tslint:align) @typescript-eslint/tslint/config

Expected Behavior

I don't really mind which convention is accepted as long as its consistent.

Reproduction

constructor(private router: Router,
            private authenticationService: AuthenticationService,
            private tokenService: TokenService) {}

constructor(private router: Router,
  private authenticationService: AuthenticationService,
  private tokenService: TokenService) { }

{
    "rules": {
        "@typescript-eslint/indent": [
            "error",
            2
        ],
        "@typescript-eslint/tslint/config": [
            "error",
            {
                "rulesDirectory": [
                    "**MyPath**"
                ],
                "rules": {
                    "align": [
                        true,
                        "parameters",
                        "statements"
                    ]
                }
            }
        ]
    }
}

[JoshuaKGoldberg]

Thanks for the report @rhysowen9! It sounds like the align rule needs a converter that outputs the @typescript-eslint/indent rule. Accepting PRs to add that in.

docs/Development.md has a root overview for how to get started. Within that, docs/Architecture.md#rule-converters talks about how these converters operate.

[KingDarBoja]

@JoshuaKGoldberg I do think it is already fixed because I see the rule on the converters map.

[JoshuaKGoldberg]

@KingDarBoja the issue here is that TSLint's align rule isn't yet converted - not the indent one, sadly.

[KingDarBoja]

@KingDarBoja the issue here is that TSLint's align rule isn't yet converted - not the indent one, sadly.

I will look into it these days 🍰

UPDATE @JoshuaKGoldberg We can't implement a converter for the align rule as it hasn't implementation on ESLint as you can check on the roadmap.

[jeremyyap]

May I work on this? typescript-eslint's indent rule supports an indentation level of "first" which should be similar to what TSLint's align rule enforces:

the string "first" indicating that all parameters of the declaration must be aligned with the first parameter