-
Notifications
You must be signed in to change notification settings - Fork 100
Closed
Labels
area: incorrect converterRule converter with incomplete, incorrect, or invalid rule names and/or argumentsRule converter with incomplete, incorrect, or invalid rule names and/or argumentsgood first issueGood for newcomers; welcome aboard!Good for newcomers; welcome aboard!status: accepting prsPlease, send in a PR to resolve this! ✨Please, send in a PR to resolve this! ✨type: bugSomething isn't workingSomething isn't working
Description
PascalCase and snake_case configuration options never get migrated to eslint because formats variable is not used anywhere.
See:
tslint-to-eslint-config/src/converters/lintConfigs/rules/ruleConverters/variable-name.ts
Lines 40 to 63 in 7c92c87
| const formats = ["camelCase", "UPPER_CASE"]; | |
| if (hasCheckFormat && allowPascalCase) { | |
| formats.push("PascalCase"); | |
| } | |
| if (hasCheckFormat && allowSnakeCase) { | |
| formats.push("snake_case"); | |
| } | |
| if (!hasCheckFormat) { | |
| camelCaseRules.push({ | |
| selector: "variable", | |
| format: ["camelCase", "UPPER_CASE"], | |
| leadingUnderscore: "forbid", | |
| trailingUnderscore: "forbid", | |
| }); | |
| } else { | |
| camelCaseRules.push({ | |
| selector: "variable", | |
| format: ["camelCase", "UPPER_CASE"], | |
| leadingUnderscore: allowedLeadingUnderscore ? "allow" : "forbid", | |
| trailingUnderscore: allowedTrailingUnderscore ? "allow" : "forbid", | |
| }); | |
| } |
Metadata
Metadata
Assignees
Labels
area: incorrect converterRule converter with incomplete, incorrect, or invalid rule names and/or argumentsRule converter with incomplete, incorrect, or invalid rule names and/or argumentsgood first issueGood for newcomers; welcome aboard!Good for newcomers; welcome aboard!status: accepting prsPlease, send in a PR to resolve this! ✨Please, send in a PR to resolve this! ✨type: bugSomething isn't workingSomething isn't working