Treat QuerySet.alias like QuerySet.annotate
#2411
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Although this incorrectly allows some misuses of `alias` that only work at runtime with `annotate`, that is better than incorrectly forbidding all uses of `alias`. Fixes typeddjango#2302. Signed-off-by: Anders Kaseorg <[email protected]>
sobolevn
approved these changes
Oct 21, 2024
Member
sobolevn
left a comment
sobolevn
left a comment
There was a problem hiding this comment.
Thanks! Further improvements of alias() are welcome!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Although this incorrectly allows some misuses of
aliasthat only work at runtime withannotate, that is better than incorrectly forbidding all uses ofalias.filteraQuerySeton analias#2302.