This repository was archived by the owner on Oct 9, 2023. It is now read-only.
Close Transactions Properly #45
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flyingsilverfin
force-pushed
the
proper-test-cleanup
branch
from
2d7ed3a to
8364cb3
Compare
flyingsilverfin
commented
May 13, 2019
lolski
reviewed
May 13, 2019
lolski
approved these changes
May 13, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the goal of this PR?
Properly close transactions that was leading to failing client-python tests, and ensure that tests that are failing clean up properly rather than exiting without closing transactions.
What are the changes implemented in this PR?
onCompleted()is called on the server. Previously, we were emptying the input iterator and addingNoneto its queue, but this was not being consumed. Thus, the transactions was not being cleaned up on the server as thetransaction(stream)RPC call was never completed cleanly.addCleanupto close transactions even if the tests fail - this is always executed regardless of test status.Closes #44