Skip to content
This repository was archived by the owner on Oct 9, 2023. It is now read-only.

Conversation

jamesreprise
Copy link
Contributor

@jamesreprise jamesreprise commented Oct 3, 2022

What is the goal of this PR?

We remove an unneccessary call of pip_repositories despite it being a deprecated function from rules_python, including in our own patched version. Additionally, this cleans up our bazel command output. See the output message below.

DEBUG: /private/var/tmp/[...]/external/rules_python/python/pip.bzl:228:10: 
DEPRECATED: the pip_repositories rule has been replaced with pip_install, please see rules_python 0.1 release notes

See this dependencies PR for more information:

What are the changes implemented in this PR?

We remove the command that loads the function as well as the call to the function.

@grabl
Copy link
Contributor

grabl commented Oct 3, 2022

PR Review Checklist

Do not edit the content of this comment. The PR reviewer should simply update this comment by ticking each review item below, as they get completed.


Code

  • Packages, classes, and methods have a single domain of responsibility.
  • Packages, classes, and methods are grouped into cohesive and consistent domain model.
  • The code is canonical and the minimum required to achieve the goal.
  • Modules, libraries, and APIs are easy to use, robust (foolproof and not errorprone), and tested.
  • Logic and naming has clear narrative that communicates the accurate intent and responsibility of each module (e.g. method, class, etc.).
  • The code is algorithmically efficient and scalable for the whole application.

Architecture

  • Any required refactoring is completed, and the architecture does not introduce technical debt incidentally.
  • Any required build and release automations are updated and/or implemented.
  • Any new components follows a consistent style with respect to the pre-existing codebase.
  • The architecture intuitively reflects the application domain, and is easy to understand.
  • The architecture has a well-defined hierarchy of encapsulated components.
  • The architecture is extensible and scalable.

@jamesreprise jamesreprise merged commit a850b2e into typedb:master Oct 3, 2022
@jamesreprise jamesreprise added this to the Technical Debt milestone Oct 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants