This repository was archived by the owner on Oct 9, 2023. It is now read-only.
Query iterator only throws exeption once #252
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flyingsilverfin
commented
Mar 22, 2022
Comment on lines
-136
to
-137
| value = self._stream.fetch(self._request_id) | ||
| return value |
Comment on lines
+62
to
+65
| elif response.is_done() and response.error is None: | ||
| raise TypeDBClientException.of(TRANSACTION_CLOSED) | ||
| elif response.is_done() and response.error is not None: | ||
| raise TypeDBClientException.of_rpc(response.error) |
There was a problem hiding this comment.
go back to the old behaviour of retrieving the error from the Done message stored in the queue, which will be thrown exactly once. After that, this queue will always throw transaction closed.
| raise TypeDBClientException.of(ILLEGAL_STATE) | ||
|
|
||
| def __next__(self) -> transaction_proto.Transaction.ResPart: | ||
| if self._bidirectional_stream.get_error() is not None: |
There was a problem hiding this comment.
the error will come from the backing Queue, rather than the bidirectional stream.
|
@flyingsilverfin lol |
alexjpwalker
approved these changes
Mar 22, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the goal of this PR?
Revert previous changes from #247 and #248, which made query queues and iterators throw the same error idempotently. However, this goes counter to standard usage of iterators and queues, which are not meant to behave idempotently (each item is only returned once, and if they have an error they should no longer be used).
What are the changes implemented in this PR?
Note: mirrors change from typedb/typedb-driver#372