Skip to content
This repository was archived by the owner on Oct 9, 2023. It is now read-only.
This repository was archived by the owner on Oct 9, 2023. It is now read-only.

Project requirements are specified in (at least) two places #219

@alexjpwalker

Description

@alexjpwalker

Problem to Solve

requirements_dev.txt was added in order to provide a convenient way of installing dev dependencies that we only need when developing Client Python, not when you simply want to use it. This is akin to devDependencies in package.json of client-nodejs. It includes a test framework, behave, and an assertion framework PyHamcrest.

But it's an ugly solution. We now have to specify the version of, for example, grakn-protocol in 2 places - requirements.txt and requirements_dev.txt.

Proposed Solution

I originally created this split so that we would only have to run one command: pip install -r requirements_dev.txt. But perhaps running two commands is a better option (i.e. yank the prod requirements out of requirements_dev, hence requiring that we run both.)

After all, this is also something Bazel build should be able to do automatically for us. I've noticed that we do have a pip_install rule in our WORKSPACE, and yet it doesn't seem to actually install the packages from what I can tell. I always have to run pip install myself manually after the Bazel build.

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions