Skip to content

support pypirc_repository in deploy_pip facade #408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

support pypirc_repository in deploy_pip facade #408

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion pip/rules.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -380,7 +380,17 @@ _deploy_pip = rule(
"""
)

def deploy_pip(name, target, snapshot, release, suffix = "", distribution_tag = "py3-none-any"):

def deploy_pip(name, target, snapshot = "", release = "", pypirc_repository = "", suffix = "", distribution_tag = "py3-none-any"):
if (snapshot and release and pypirc_repository):
fail("Only one 'snapshot and release' or 'pypirc_repository' may be set")
if (not snapshot and not release and not pypirc_repository):
fail("At least one 'snapshot and release' or 'pypirc_repository' must be set")
if (snapshot and not release):
fail("'release' repository param must be set if 'snapshot' repository is configured")
if (not snapshot and release):
fail("'snapshot' repository param must be set if 'release' repository is configured")

deploy_script_target_name = name + "__deploy"
deploy_script_name = deploy_script_target_name + "-deploy.py"
_deploy_pip(
Expand All @@ -389,6 +399,7 @@ def deploy_pip(name, target, snapshot, release, suffix = "", distribution_tag =
target = target,
snapshot = snapshot,
release = release,
pypirc_repository = pypirc_repository,
suffix = suffix,
distribution_tag = distribution_tag,
)
Expand Down