Skip to content

Anchor watcher ignore patterns at the project root #208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 11, 2018
Merged

Anchor watcher ignore patterns at the project root #208

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
34902dd
Anchor watcher ignore patterns at the project root
dfreeman May 11, 2018
70fa640
Merge branch 'master' into fix-ignore-pattern
chriskrycho May 11, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions lib/utilities/compile.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@

const chokidar = require('chokidar');
const fs = require('fs-extra');
const escapeRegex = require('escape-string-regexp');
const debug = require('debug')('ember-cli-typescript:tsc:trace');

module.exports = function compile(project, tsOptions, callbacks) {
Expand All @@ -23,7 +24,7 @@ module.exports = function compile(project, tsOptions, callbacks) {
let host = ts.createWatchCompilerHost(
configPath,
fullOptions,
buildWatchHooks(ts.sys, callbacks),
buildWatchHooks(project, ts.sys, callbacks),
createProgram,
diagnosticCallback(callbacks.reportDiagnostic),
diagnosticCallback(callbacks.reportWatchStatus)
Expand All @@ -47,13 +48,17 @@ function diagnosticCallback(callback) {
}
}

function buildWatchHooks(sys, callbacks) {
function buildWatchHooks(project, sys, callbacks) {
let root = escapeRegex(project.root);
let sep = `[/\\\\]`;
let patterns = ['\\..*?', 'dist', 'node_modules', 'tmp'];
let ignored = new RegExp(`^${root}${sep}(${patterns.join('|')})${sep}`);

return Object.assign({}, sys, {
watchFile: null,
watchDirectory(dir, callback) {
if (!fs.existsSync(dir)) return;

let ignored = /\/(\..*?|dist|node_modules|tmp)\//;
let watcher = chokidar.watch(dir, { ignored, ignoreInitial: true });

watcher.on('all', (type, path) => {
Expand Down
1 change: 1 addition & 0 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,7 @@
"ember-cli-valid-component-name": "^1.0.0",
"ember-cli-version-checker": "^2.1.0",
"ember-router-generator": "^1.2.3",
"escape-string-regexp": "^1.0.5",
"execa": "^0.9.0",
"exists-sync": "^0.0.4",
"fs-extra": "^5.0.0",
Expand Down