Skip to content
This repository was archived by the owner on Mar 4, 2021. It is now read-only.

Conversation

frederickding
Copy link

Resubmission of #260 on the develop branch.

In order to maintain the cleanliness of the develop-branch version history, I cherry picked the commits from master instead of merging.

- Also applied changes to OpenVBX core files to fix compatibility
- See #258
- Also see 4d899e1 in master branch
- May cause issues for installations that are not being rewritten
- Installation-specific options should be saved in `-local.php` config files!
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this causing a problem or is it obsolete? If obsolete (which, if my quick search is correct, it is) this and its associated documentation comment should just be removed.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed, plugins have been deprecated. I will remove the block.

@Gipetto
Copy link
Contributor

Gipetto commented Feb 3, 2014

Looks good pending a few minor things.

- Merged `autoload.php` from bcit-ci/CodeIgniter@88cf55b
- Reenabled `$config['enable_query_strings']`
- Removed commented code per code review in #261
@Gipetto
Copy link
Contributor

Gipetto commented Feb 3, 2014

Awesome. I'm gonna try to give this a run through in the next week. Unfortunately our test coverage is pathetic so everything has to be tested manually.

@Gipetto
Copy link
Contributor

Gipetto commented Feb 10, 2014

There are duplicate MY_ files in OpenVBX/core and OpenVBX/libraries. Which of these are actually in use?

@Gipetto
Copy link
Contributor

Gipetto commented May 22, 2014

I've tried to get this fully tested a couple of times but have hit a few blockers. I don't have them handy but hope to be able to swing back around to this.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants