Skip to content

Add class comparison between base and linear-base #368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 16, 2022
Merged

Add class comparison between base and linear-base #368

merged 2 commits into from
Mar 16, 2022

Conversation

tbagrel1
Copy link
Member

At the moment, only classes present in Prelude or Prelude.Linear are shown.

tbagrel1
tbagrel1 commented Feb 11, 2022
View reviewed changes
Copy link
Member Author

@tbagrel1 tbagrel1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note to myself: missing items

@tbagrel1 tbagrel1 linked an issue Feb 11, 2022 that may be closed by this pull request
Add a comparison table between base and linear-base classes (and types, maybe) ? #376
Closed
@tbagrel1 tbagrel1 marked this pull request as ready for review February 23, 2022 13:50
@tbagrel1 tbagrel1 force-pushed the tbagrel1/readme-class-table branch 2 times, most recently from b3bef03 to e1e72ae Compare February 25, 2022 14:43
@tbagrel1 tbagrel1 mentioned this pull request Mar 2, 2022
Draft
aspiwack
aspiwack reviewed Mar 7, 2022
View reviewed changes
Copy link
Member

@aspiwack aspiwack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a good table. It's good to have. But I'm of the opinion that it's too big for a README. Let's put the table in a dedicated Markdown file, in the doc/ subdirectory, and put a link in the README.

@tbagrel1 tbagrel1 force-pushed the tbagrel1/readme-class-table branch 2 times, most recently from d1ede32 to 9588a63 Compare March 10, 2022 09:29
@tbagrel1 tbagrel1 changed the title Add class comparison between base and linear-base in the README Add class comparison between base and linear-base Mar 10, 2022
Topsii
Topsii reviewed Mar 12, 2022
View reviewed changes
@tbagrel1 tbagrel1 force-pushed the tbagrel1/readme-class-table branch from 5481781 to 26cbdbd Compare March 16, 2022 12:36
@tbagrel1 tbagrel1 requested a review from aspiwack March 16, 2022 12:41
@tbagrel1 tbagrel1 force-pushed the tbagrel1/readme-class-table branch from 26cbdbd to 84c9afc Compare March 16, 2022 13:34
@tbagrel1 tbagrel1 merged commit 9d82f67 into master Mar 16, 2022
@tbagrel1 tbagrel1 deleted the tbagrel1/readme-class-table branch March 16, 2022 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aspiwack aspiwack aspiwack approved these changes

+1 more reviewer

@Topsii Topsii Topsii left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add a comparison table between base and linear-base classes (and types, maybe) ?
3 participants
@tbagrel1 @aspiwack @Topsii