Skip to content

Fix for HumanNameParser incorrectly interprets some name components as postnominals #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 1, 2025
Merged

Fix for HumanNameParser incorrectly interprets some name components as postnominals #17

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 12 additions & 4 deletions src/main/java/com/tupilabs/human_name_parser/HumanNameParserBuilder.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,16 +137,16 @@ public HumanNameParserBuilder(Name name) {
*/
public HumanNameParserParser build() {
if (this.salutations == null) {
this.salutations = DEFAULT_SALUTATIONS;
this.salutations = formatToRegex(DEFAULT_SALUTATIONS);
}
if (this.postnominals == null) {
this.postnominals = DEFAULT_POSTNOMINALS;
this.postnominals = formatToRegex(DEFAULT_POSTNOMINALS);
}
if (this.prefixes == null) {
this.prefixes = DEFAULT_PREFIXES;
this.prefixes = formatToRegex(DEFAULT_PREFIXES);
}
if (this.suffixes == null) {
this.suffixes = DEFAULT_SUFFIXES;
this.suffixes = formatToRegex(DEFAULT_SUFFIXES);
}
final HumanNameParserParser parser = new HumanNameParserParser(
name,
Expand All @@ -159,6 +159,14 @@ public HumanNameParserParser build() {
return parser;
}

private List<String> formatToRegex(List<String> list) {
List<String> regexList = new ArrayList<>();
for (String s : list) {
regexList.add(s.replace(".", "\\."));
}
return regexList;
}

// salutations

public HumanNameParserBuilder withSalutations(List<String> salutations) {
Expand Down
8 changes: 8 additions & 0 deletions src/test/java/com/tupilabs/human_name_parser/BuilderTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,6 +141,14 @@ public void testExtraSalutations() {
assertTrue(parser.salutations.contains("sinho"));
}

@Test
public void testLastNameNotMistakenForPostnominal() {
HumanNameParserBuilder builder = new HumanNameParserBuilder("ruvin phidd");
HumanNameParserParser parser = builder.build();
assertTrue(parser.getFirst().contains("ruvin"));
assertTrue(parser.getLast().contains("phidd"));
}

// validations

@Test
Expand Down