Skip to content

Conversation

kinow
Copy link
Member

@kinow kinow commented Jul 8, 2020

Closes #10

@JamoCA I'm adding a unit test and the changelog, then it should be ready for review. Instead of changing the parser to support these postnominals, I created a new builder.

The HumanNamesParserBuilder must be used to create a parser. You just need to give it a String or Name object, similar to how you would create a parser in 0.1.

But you can (not required) to:

  • pass lists to replace the default salutations, postnominals, suffixes, and prefixes
  • pass lists to append to the default values, instead of replacing them

This should allow us to either add more pre-defined values later if necessary, or at least give users the option to provide their own custom lists.

Let me know if you think this would work for your case.

Cheers
Bruno

@kinow kinow self-assigned this Jul 8, 2020
@kinow kinow added this to the 0.2 milestone Jul 8, 2020
@kinow kinow force-pushed the create-a-builder branch from afa4c57 to 4732b67 Compare July 8, 2020 09:35
@kinow kinow force-pushed the create-a-builder branch from 4732b67 to c97a23f Compare July 8, 2020 09:38
@kinow kinow force-pushed the create-a-builder branch from b244d14 to 88c9286 Compare July 8, 2020 11:58
@kinow kinow force-pushed the create-a-builder branch from 88c9286 to 24f5c80 Compare July 8, 2020 12:01
@kinow kinow merged commit 27422d6 into tupilabs:master Jul 8, 2020
@kinow kinow deleted the create-a-builder branch July 8, 2020 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support custom postnominals

1 participant