Create a builder allowing different salutations, postnominals, suffixes, and prefixes #11
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #10
@JamoCA I'm adding a unit test and the changelog, then it should be ready for review. Instead of changing the parser to support these postnominals, I created a new builder.
The
HumanNamesParserBuilder
must be used to create a parser. You just need to give it aString
orName
object, similar to how you would create a parser in 0.1.But you can (not required) to:
This should allow us to either add more pre-defined values later if necessary, or at least give users the option to provide their own custom lists.
Let me know if you think this would work for your case.
Cheers
Bruno