canonical sorting

[mufernando]

Currently, sort does not put a Table Collection in canonical form (given the order of nodes) -- see #705 .

Here I am working on adding mutation time, mutation parent and node to the mutation sorting key.

(still very early, working on a python impl of sort first!)

[jeromekelleher]

Looks great @mufernando, this is exatctly the right approach. Ping me when you'd like some feedback.

[codecov]

Codecov Report

Merging #715 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #715   +/-   ##
=======================================
  Coverage   87.46%   87.46%           
=======================================
  Files          24       24           
  Lines       18162    18162           
  Branches     3609     3609           
=======================================
  Hits        15886    15886           
  Misses       1099     1099           
  Partials     1177     1177           

Flag	Coverage Δ
#c_tests	89.00% <ø> (ø)
#python_c_tests	90.61% <ø> (ø)
#python_tests	99.00% <ø> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9e96bf4...c543d3e. Read the comment docs.

[jeromekelleher]

@mufernando - is this something that we want to get in for the C API release, or will having it done for the next Python release be enough? We'd really like to get the C API shipped soon, and I think just getting the sorting requirement done will be enough for that. Is that OK, or do you want the canonicalise (or whatever) method to do into the C API in time for the next release too? (The only practical reason for this is if you want to use it in SLiM, I think)

[mufernando]

I don't need this in SLiM and probably won't be able to get to this over the next week or two, so we can wait for the next release.

[benjeffery]

@mufernando Just pinging as this PR has been inactive for a while - do you plan to pick it up?

[mufernando]

I don't think I'll have the time to work on this for a while. But it seems the work I did with validating the C sort with a Python implementation could be incorporated. Is it bad to leave this hanging here?

[benjeffery]

It's no problem to leave it - just useful for planning releases to know which PRs are still active.

[benjeffery]

Superseded by #1108